Make glib namespace optional #1684
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some introspectiable liberies don't include glib in the gir file. For example `gsettings-dekstop-schemas` only exposes a series of enumes but doesn't depend on glib.
sdroege
reviewed
Oct 18, 2025
| None | ||
| } else { | ||
| let ns = if env.namespaces.glib_ns_id == namespaces::MAIN { | ||
| let ns = if env.namespaces.glib_ns_id.is_none() |
Member
There was a problem hiding this comment.
This and other code should panic if the GLib namespace is not found. It's using API from it so the namespace must exist in these situations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some introspectiable liberies don't include glib in the gir file. For example
gsettings-dekstop-schemasonly exposes a series of enumes but doesn't depend on glib.CC: @sdroege