This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Check subclass gtk check #745
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
check-subclass-gtk-check
branch
2 times, most recently
from
ba93ca8
to
364830f
Compare
GuillaumeGomez
force-pushed
the
check-subclass-gtk-check
branch
from
364830f
to
c89f7e9
Compare
sdroege
reviewed
Apr 26, 2022
There was a problem hiding this comment.
Seems fine to me if we just want to add it everywhere instead of deciding case by case. @bilelmoussaoui ?
|
Still remains the question if we should put this check before running it in the parent. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So in case we want to enforce this checks at all levels, this check enforces it.