Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdk: Rename GdkCairoContextExt::set_source_{rgba => color} #1476

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

RealKC
Copy link
Contributor

@RealKC RealKC commented Aug 22, 2023

This is a breaking change

Fixes #1469

@RealKC RealKC changed the title gdk: Rename GdkCairoContextExt::set_source_{rgba => colour} gdk: Rename GdkCairoContextExt::set_source_{rgba => color} Aug 22, 2023
@RealKC RealKC force-pushed the rename-gdkcairoext-set-rgba branch from 6d633b6 to b0da38a Compare August 22, 2023 16:44
@RealKC
Copy link
Contributor Author

RealKC commented Aug 22, 2023

CI failures seem unrelated, I did not modify gsk. I think Bilal has a PR that would fix it?

@bilelmoussaoui
Copy link
Member

The CI should pass once I merged #1475

@RealKC RealKC force-pushed the rename-gdkcairoext-set-rgba branch from b0da38a to 4d3f8db Compare August 22, 2023 18:51
@bilelmoussaoui
Copy link
Member

Rebasing should fix the CI

@RealKC RealKC force-pushed the rename-gdkcairoext-set-rgba branch from 9933eed to cd93785 Compare August 22, 2023 19:12
@RealKC RealKC force-pushed the rename-gdkcairoext-set-rgba branch 6 times, most recently from 9b2aa39 to 2136b07 Compare August 22, 2023 19:58
@RealKC RealKC force-pushed the rename-gdkcairoext-set-rgba branch from 2136b07 to 75dfa9e Compare August 22, 2023 20:11
Copy link
Member

@bilelmoussaoui bilelmoussaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm, thanks a lot

gdk4/Cargo.toml Show resolved Hide resolved
@RealKC RealKC force-pushed the rename-gdkcairoext-set-rgba branch from 75dfa9e to 40f5be9 Compare August 22, 2023 20:18
@bilelmoussaoui bilelmoussaoui merged commit 3807daa into gtk-rs:master Aug 22, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GdkCairoContextExt::set_source_rgba clashes with Context::set_source_rgba
2 participants