-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdk: Rename GdkCairoContextExt::set_source_{rgba => color}
#1476
Merged
bilelmoussaoui
merged 3 commits into
gtk-rs:master
from
RealKC:rename-gdkcairoext-set-rgba
Aug 22, 2023
Merged
gdk: Rename GdkCairoContextExt::set_source_{rgba => color}
#1476
bilelmoussaoui
merged 3 commits into
gtk-rs:master
from
RealKC:rename-gdkcairoext-set-rgba
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealKC
changed the title
gdk: Rename
gdk: Rename Aug 22, 2023
GdkCairoContextExt::set_source_{rgba => colour}
GdkCairoContextExt::set_source_{rgba => color}
RealKC
force-pushed
the
rename-gdkcairoext-set-rgba
branch
from
August 22, 2023 16:44
6d633b6
to
b0da38a
Compare
CI failures seem unrelated, I did not modify gsk. I think Bilal has a PR that would fix it? |
The CI should pass once I merged #1475 |
RealKC
force-pushed
the
rename-gdkcairoext-set-rgba
branch
from
August 22, 2023 18:51
b0da38a
to
4d3f8db
Compare
Rebasing should fix the CI |
RealKC
force-pushed
the
rename-gdkcairoext-set-rgba
branch
from
August 22, 2023 19:12
9933eed
to
cd93785
Compare
RealKC
commented
Aug 22, 2023
RealKC
force-pushed
the
rename-gdkcairoext-set-rgba
branch
6 times, most recently
from
August 22, 2023 19:58
9b2aa39
to
2136b07
Compare
RealKC
force-pushed
the
rename-gdkcairoext-set-rgba
branch
from
August 22, 2023 20:11
2136b07
to
75dfa9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm, thanks a lot
RealKC
force-pushed
the
rename-gdkcairoext-set-rgba
branch
from
August 22, 2023 20:18
75dfa9e
to
40f5be9
Compare
bilelmoussaoui
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change
Fixes #1469