-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
book: Extend main loop chapter with async section #1511
Conversation
21f79cf
to
142840b
Compare
Let me know when you want me to go over it for a review :) |
Thanks! Will do that :) |
Co-authored-by: Bilal Elmoussaoui <[email protected]>
a99748b
to
c35484d
Compare
@sdroege @felinira this PR is now ready for review. Feel free to also comment on parts of the chapter that wasn't touched by this PR. You can render it locally by running:
CI fails because I reference listings that will be there after this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not run the examples, but I've gone through everything and made some suggestions. Overall this is looking pretty good and is a useful addition I think :)
Co-authored-by: Fina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @felinira!
Your suggestions make sense to me and I applied most of the immediately :)
Co-authored-by: Fina <[email protected]>
A bit late, but I went through everything now and don't have a single suggestion what to change. Good work, this is a lot more understandable and short than what I would've come up with :) |
See discussion in #1508
gio::spawn_blocking