Remove unnecessary upcast from examples/squeezer_bin/main.rs #1763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this example runs as expected even without
.upcast::<gtk::Widget>()
I have a limited understanding of the language and libraries. I welcome pedantic feedback.
What I understand is that
SqueezerBin.set_child()
expects an argument of typeOption<>k::Widget>
gtk4-rs/examples/squeezer_bin/squeezer_bin/imp.rs
Line 26 in 5340715
gtk::Label
extendsgtk::Widget
, so I believe the type constraint is already satisfiedgtk4-rs/gtk4/src/auto/label.rs
Line 36 in 5340715
Try it yourself
cd
in theexamples
directorycargo run --bin squeezer_bin