Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary upcast from examples/squeezer_bin/main.rs #1763

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

mtilda
Copy link
Contributor

@mtilda mtilda commented Jun 2, 2024

I noticed this example runs as expected even without .upcast::<gtk::Widget>()

I have a limited understanding of the language and libraries. I welcome pedantic feedback.

What I understand is that

Try it yourself

  1. Clone this repository
  2. cd in the examples directory
  3. Run the command cargo run --bin squeezer_bin

@mtilda
Copy link
Contributor Author

mtilda commented Jun 5, 2024

@bilelmoussaoui any thoughts on this? Have you found time to test the change?

@sdroege sdroege merged commit d1c8a6f into gtk-rs:master Jun 8, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants