book: Make book listings work on macos by using glib user_data_dir #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the dirs crate still used elsewhere? If not, maybe remove it completely |
daxhuiberts
force-pushed
the
make-book-listings-work-on-macos
branch
from
7e32703
to
8775196
Compare
Good suggestion. It was only used in the xtask, so I removed it. |
|
lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dirs::data_dir()returns a different directory that glib expects for the schemas on macos (see https://docs.rs/dirs/latest/dirs/fn.data_dir.html)Using
glib::user_data_dir()instead will return the expected directory for glib.