Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

pango-sys: Drop v1_36_7 feature #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ignatenkobrain
Copy link
Contributor

It is not handled anywhere, so it would fall back into 1.36 which is default.

It is not handled anywhere, so it would fall back into 1.36 which is default.
ignatenkobrain added a commit to ignatenkobrain/pango that referenced this pull request Apr 28, 2019
@EPashkin
Copy link
Member

Restarting CI

@EPashkin
Copy link
Member

@ignatenkobrain, @GuillaumeGomez I was careless when checking, it really used in PangoAnalysis for flags.

    <constant name="ANALYSIS_FLAG_IS_ELLIPSIS" value="2" c:type="PANGO_ANALYSIS_FLAG_IS_ELLIPSIS" version="1.36.7">
      <doc xml:space="preserve">This flag is used to mark runs that hold ellipsized text,
in an ellipsized layout.</doc>
      <type name="gint" c:type="gint"/>
    </constant>

As we don't define constants and use flags directly https://github.com/gtk-rs/pango/blob/master/src/analysis.rs#L38 IMHO we can just leave pango's fix and close this PR.

GuillaumeGomez pushed a commit to gtk-rs/gtk3-rs that referenced this pull request Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants