Import cleanup #16368
Merged
Import cleanup #16368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR build results: screenshots exceptions (0) webpagetest (2) -automated message |
jfsoul
reviewed
Apr 5, 2017
| @@ -88,17 +87,10 @@ object Frontend extends Build with Prototypes { | |||
| libraryDependencies ++= Seq( | |||
| paClient, | |||
| akkaContrib | |||
| ), | |||
| TwirlKeys.templateImports ++= Seq( | |||
jfsoul
reviewed
Apr 5, 2017
| @@ -3,8 +3,7 @@ | |||
| @import implicits.Football._ | |||
| @import views.FootballHelpers._ | |||
|
|
|||
|
|
|||
| @(page: MatchPage, competition: Option[model.Competition])(implicit request: RequestHeader, context: model.ApplicationContext) | |||
| @(page: _root_.football.controllers.MatchPage, competition: Option[model.Competition])(implicit request: RequestHeader, context: model.ApplicationContext) | |||
There was a problem hiding this comment.
I'm not sure I understand why these have to be _root_, is there another MatchPage it might pick up otherwise?
There was a problem hiding this comment.
You are right. It is not necessary.
However IntelliJ is confused and pick up the football package from another app (admin). That's why I originally added _root_.
I removed it and will try to fix IntelliJ instead
There was a problem hiding this comment.
will try to fix IntelliJ instead
Good luck, you may need it! 😄
jfsoul
approved these changes
Apr 5, 2017
NataliaLKB
approved these changes
Apr 5, 2017
It makes templates dependencies hard to follow. Instead importing the necessary dependencies in each templates
TBonnin
force-pushed
the
tb-unused-imports
branch
from
6c91e24 to
3a3a4fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This patch:
TwirlKeys.templateImportssetting: It makes templates dependencies hard to follow. Instead importing the necessary dependencies in each templates.Example:
footballtemplates were automatically importingpa._which provides an implicitStringToOptionfunction. It was not clear to me why passing aStringto a fragment that was expecting anOption[String]argument was compiling successfullyI wanted to enable the
-Ywarn-unused-importcompiler option but it doesn't play well with Twirl templates: playframework/twirl#105What is the value of this and can you measure success?
More explicit dependencies, less hidden magic
Tested in CODE?
yes