Skip to content

feat: add checkout redirect without qs params #6117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jamesgorrie
Copy link
Contributor

@jamesgorrie jamesgorrie commented Jun 19, 2024

The identity API strips out querystring parameters for security reasons.

see https://github.com/guardian/gateway/blob/940e33d41e0921fd96db9370f195a93ef1787858/src/server/lib/validateUrl.ts

This offers a URL that takes specific URL path segments, and breaks them into a querystring.

This is in draft as ID are looking if they can append QS parameters which would make this obsolete

The identity API strips out querystring parameters for security reasons.
@see https://github.com/guardian/gateway/blob/940e33d41e0921fd96db9370f195a93ef1787858/src/server/lib/validateUrl.ts

This offers a URL that takes specific URL path segments, and breaks them into a querystring.
Copy link
Contributor

github-actions bot commented Jun 19, 2024

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Size Change: 0 B

Total Size: 2.17 MB

ℹ️ View Unchanged
Filename Size
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 98.5 kB
./public/compiled-assets/javascripts/[countryGroupId]/router.js 232 kB
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 226 kB
./public/compiled-assets/javascripts/downForMaintenancePage.js 69.5 kB
./public/compiled-assets/javascripts/error404Page.js 69.5 kB
./public/compiled-assets/javascripts/error500Page.js 69.4 kB
./public/compiled-assets/javascripts/favicons.js 618 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 171 kB
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 86.3 kB
./public/compiled-assets/javascripts/payPalErrorPage.js 67.9 kB
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B
./public/compiled-assets/javascripts/promotionTerms.js 72.6 kB
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 71.7 kB
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 126 kB
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 300 kB
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 190 kB
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 86.4 kB
./public/compiled-assets/webpack/385.js 81.8 kB
./public/compiled-assets/webpack/630.js 2.03 kB
./public/compiled-assets/webpack/775.js 18.1 kB
./public/compiled-assets/webpack/890.js 19.8 kB
./public/compiled-assets/webpack/991.js 2.17 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant