Skip to content

Disable back button for student offer #7132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025
Merged

Conversation

maloky
Copy link
Contributor

@maloky maloky commented Jul 8, 2025

What are you doing in this PR?

Disable back button on the checkout order summary using a query param.

Trello Card

Why are you doing this?

There is no point to having the back navigations because there aren't any other options to choose from on the student page.

How to test

How can we measure success?

Have we considered potential risks?

Accessibility test checklist

Screenshots

Copy link
Contributor

github-actions bot commented Jul 8, 2025

Size Change: +44 B (0%)

Total Size: 1.53 MB

ℹ️ View Unchanged
Filename Size Change
./support-frontend/public/compiled-assets/javascripts/[countryGroupId]/events/router.js 101 kB 0 B
./support-frontend/public/compiled-assets/javascripts/[countryGroupId]/router.js 124 kB -1 B (0%)
./support-frontend/public/compiled-assets/javascripts/ausMomentMap.js 109 kB 0 B
./support-frontend/public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./support-frontend/public/compiled-assets/javascripts/downForMaintenancePage.js 71.6 kB 0 B
./support-frontend/public/compiled-assets/javascripts/error404Page.js 71.5 kB 0 B
./support-frontend/public/compiled-assets/javascripts/error500Page.js 71.5 kB 0 B
./support-frontend/public/compiled-assets/javascripts/favicons.js 618 B 0 B
./support-frontend/public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 96.7 kB 0 B
./support-frontend/public/compiled-assets/javascripts/payPalErrorPage.js 70.4 kB 0 B
./support-frontend/public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./support-frontend/public/compiled-assets/javascripts/promotionTerms.js 78 kB 0 B
./support-frontend/public/compiled-assets/javascripts/subscriptionsLandingPage.js 103 kB 0 B
./support-frontend/public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./support-frontend/public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 162 kB 0 B
./support-frontend/public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 96 kB 0 B
./support-frontend/public/compiled-assets/webpack/142.js 7.75 kB 0 B
./support-frontend/public/compiled-assets/webpack/241.js 4.25 kB 0 B
./support-frontend/public/compiled-assets/webpack/249.js 34.8 kB 0 B
./support-frontend/public/compiled-assets/webpack/340.js 4.99 kB 0 B
./support-frontend/public/compiled-assets/webpack/491.js 4.36 kB 0 B
./support-frontend/public/compiled-assets/webpack/531.js 5.78 kB 0 B
./support-frontend/public/compiled-assets/webpack/589.js 24.6 kB 0 B
./support-frontend/public/compiled-assets/webpack/655.js 3.52 kB 0 B
./support-frontend/public/compiled-assets/webpack/709.js 109 kB 0 B
./support-frontend/public/compiled-assets/webpack/747.js 3.35 kB 0 B
./support-frontend/public/compiled-assets/webpack/785.js 13.1 kB 0 B
./support-frontend/public/compiled-assets/webpack/8.js 20.1 kB 0 B
./support-frontend/public/compiled-assets/webpack/801.js 2.18 kB 0 B
./support-frontend/public/compiled-assets/webpack/826.js 14.6 kB 0 B
./support-frontend/public/compiled-assets/webpack/855.js 7.13 kB 0 B
./support-frontend/public/compiled-assets/webpack/916.js 8.9 kB 0 B
./support-frontend/public/compiled-assets/webpack/checkout.js 19.6 kB +32 B (+0.16%)
./support-frontend/public/compiled-assets/webpack/GuardianAdLiteLanding.js 13.4 kB 0 B
./support-frontend/public/compiled-assets/webpack/LandingPage.js 16.1 kB 0 B
./support-frontend/public/compiled-assets/webpack/oneTimeCheckout.js 7.38 kB 0 B
./support-frontend/public/compiled-assets/webpack/StudentLandingPage.js 6.12 kB +13 B (+0.21%)
./support-frontend/public/compiled-assets/webpack/ThankYou.js 43.6 kB 0 B

compressed-size-action

Copy link
Contributor

github-actions bot commented Jul 8, 2025

Copy link
Contributor

github-actions bot commented Jul 8, 2025

@tjmw
Copy link
Member

tjmw commented Jul 8, 2025

Disable back button on the checkout order summary using a query param.
Fetch benefits list from the pageSetting variant.

Would it be worth splitting these into separate PRs (or at least commits)? Just thinking if we wanted to roll one back but not the other that'd make it easier. I don't think there's anything that means the two are coupled?

@maloky
Copy link
Contributor Author

maloky commented Jul 8, 2025

Disable back button on the checkout order summary using a query param.
Fetch benefits list from the pageSetting variant.

Would it be worth splitting these into separate PRs (or at least commits)? Just thinking if we wanted to roll one back but not the other that'd make it easier. I don't think there's anything that means the two are coupled?

Yeah, I just took the opportunity to fix benefits since the page is not live yet. can totally split them up 👍

@maloky maloky force-pushed the jc/disable-change-button branch from 858a590 to a55a2a7 Compare July 8, 2025 09:11
@maloky maloky merged commit b512e89 into main Jul 8, 2025
21 checks passed
@maloky maloky deleted the jc/disable-change-button branch July 8, 2025 10:37
@prout-bot
Copy link

Seen on PROD (merged by @maloky 10 minutes and 35 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants