Skip to content

Fix issue with new Direct Debit icon vertical alignment #7135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Jul 9, 2025

What are you doing in this PR?

Fix the vertical alignment within the Direct Debit payment method radio on the generic checkout.

Before:

Screenshot 2025-07-09 at 10 23 50

After:

Screenshot 2025-07-09 at 10 23 23

And on mobile:

Screenshot 2025-07-09 at 11 37 40

Trello Card

Why are you doing this?

In #7077 the source library was updated and this brought in a new Direct Debit icon. This new icon slightly broke the alignment of the radio button component. Here we limit the height of the SVG icon by specifying a height for the SVG container.

In #7077 the source library was updated and this brought in a new Direct
Debit icon. This new icon slightly broke the alignment of the radio
button component. Here we limit the height of the SVG icon by specifying
a height for the SVG container.
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Size Change: +37 B (0%)

Total Size: 1.53 MB

ℹ️ View Unchanged
Filename Size Change
./support-frontend/public/compiled-assets/javascripts/[countryGroupId]/events/router.js 101 kB 0 B
./support-frontend/public/compiled-assets/javascripts/[countryGroupId]/router.js 124 kB +2 B (0%)
./support-frontend/public/compiled-assets/javascripts/ausMomentMap.js 109 kB 0 B
./support-frontend/public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./support-frontend/public/compiled-assets/javascripts/downForMaintenancePage.js 71.6 kB 0 B
./support-frontend/public/compiled-assets/javascripts/error404Page.js 71.5 kB 0 B
./support-frontend/public/compiled-assets/javascripts/error500Page.js 71.5 kB 0 B
./support-frontend/public/compiled-assets/javascripts/favicons.js 618 B 0 B
./support-frontend/public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 96.7 kB 0 B
./support-frontend/public/compiled-assets/javascripts/payPalErrorPage.js 70.4 kB 0 B
./support-frontend/public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./support-frontend/public/compiled-assets/javascripts/promotionTerms.js 78 kB 0 B
./support-frontend/public/compiled-assets/javascripts/subscriptionsLandingPage.js 103 kB 0 B
./support-frontend/public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./support-frontend/public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 162 kB 0 B
./support-frontend/public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 96 kB 0 B
./support-frontend/public/compiled-assets/webpack/142.js 7.75 kB 0 B
./support-frontend/public/compiled-assets/webpack/241.js 4.25 kB 0 B
./support-frontend/public/compiled-assets/webpack/249.js 34.8 kB 0 B
./support-frontend/public/compiled-assets/webpack/340.js 4.99 kB 0 B
./support-frontend/public/compiled-assets/webpack/491.js 4.36 kB 0 B
./support-frontend/public/compiled-assets/webpack/531.js 5.78 kB 0 B
./support-frontend/public/compiled-assets/webpack/589.js 24.6 kB 0 B
./support-frontend/public/compiled-assets/webpack/655.js 3.52 kB 0 B
./support-frontend/public/compiled-assets/webpack/709.js 109 kB 0 B
./support-frontend/public/compiled-assets/webpack/747.js 3.35 kB 0 B
./support-frontend/public/compiled-assets/webpack/785.js 13.1 kB 0 B
./support-frontend/public/compiled-assets/webpack/8.js 20.1 kB 0 B
./support-frontend/public/compiled-assets/webpack/801.js 2.18 kB 0 B
./support-frontend/public/compiled-assets/webpack/826.js 14.6 kB 0 B
./support-frontend/public/compiled-assets/webpack/855.js 7.13 kB 0 B
./support-frontend/public/compiled-assets/webpack/916.js 8.9 kB 0 B
./support-frontend/public/compiled-assets/webpack/checkout.js 19.7 kB +35 B (+0.18%)
./support-frontend/public/compiled-assets/webpack/GuardianAdLiteLanding.js 13.4 kB 0 B
./support-frontend/public/compiled-assets/webpack/LandingPage.js 16.1 kB 0 B
./support-frontend/public/compiled-assets/webpack/oneTimeCheckout.js 7.38 kB 0 B
./support-frontend/public/compiled-assets/webpack/StudentLandingPage.js 6.36 kB 0 B
./support-frontend/public/compiled-assets/webpack/ThankYou.js 43.6 kB 0 B

compressed-size-action

@tjmw tjmw merged commit 3667cf1 into main Jul 9, 2025
21 checks passed
@tjmw tjmw deleted the tw/fix-direct-debit-payment-alignment branch July 9, 2025 10:39
@prout-bot
Copy link

Seen on PROD (merged by @tjmw 11 minutes and 57 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants