Skip to content

Refactor landing page -> checkout e2e smoke tests #7148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Jul 15, 2025

What are you doing in this PR?

This is purely a refactoring to DRY up the new e2e tests which begin on the relevant landing page and navigate through to the checkout and complete a purchase. So far this has been done for the following smoke tests:

  • Ad Lite
  • Newspaper
  • 3 tier products

Why are you doing this?

I noticed while working on these tests that the one piece which differed between them was transitioning from the landing page to the checkout. The rest of the work is common. The actual checkout form work continues to be done by completeGenericCheckout.

I've added a new function visitLandingPageAndCompleteCheckout which does the common work, taking a callback to handle the navigation from landing page to checkout.

How to test

Run the smoke tests.

@tjmw tjmw changed the title Tw/refactor landing page e2e Refactor landing page -> checkout e2e smoke tests Jul 15, 2025
Call visitLandingPageAndCompleteCheckout directly from tests.
The intermediate methods weren't really adding anything any more.
@tjmw tjmw force-pushed the tw/refactor-landing-page-e2e branch from 78f2e70 to 6bc09c6 Compare July 15, 2025 09:31
Copy link
Contributor

github-actions bot commented Jul 15, 2025

Size Change: 0 B

Total Size: 1.53 MB

ℹ️ View Unchanged
Filename Size
./support-frontend/public/compiled-assets/javascripts/[countryGroupId]/events/router.js 101 kB
./support-frontend/public/compiled-assets/javascripts/[countryGroupId]/router.js 124 kB
./support-frontend/public/compiled-assets/javascripts/ausMomentMap.js 109 kB
./support-frontend/public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B
./support-frontend/public/compiled-assets/javascripts/downForMaintenancePage.js 71.6 kB
./support-frontend/public/compiled-assets/javascripts/error404Page.js 71.5 kB
./support-frontend/public/compiled-assets/javascripts/error500Page.js 71.5 kB
./support-frontend/public/compiled-assets/javascripts/favicons.js 618 B
./support-frontend/public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 96.9 kB
./support-frontend/public/compiled-assets/javascripts/payPalErrorPage.js 70.4 kB
./support-frontend/public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B
./support-frontend/public/compiled-assets/javascripts/promotionTerms.js 78 kB
./support-frontend/public/compiled-assets/javascripts/subscriptionsLandingPage.js 103 kB
./support-frontend/public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B
./support-frontend/public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 162 kB
./support-frontend/public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 96.2 kB
./support-frontend/public/compiled-assets/webpack/142.js 7.75 kB
./support-frontend/public/compiled-assets/webpack/241.js 4.25 kB
./support-frontend/public/compiled-assets/webpack/249.js 34.8 kB
./support-frontend/public/compiled-assets/webpack/340.js 4.99 kB
./support-frontend/public/compiled-assets/webpack/491.js 4.36 kB
./support-frontend/public/compiled-assets/webpack/589.js 24.6 kB
./support-frontend/public/compiled-assets/webpack/655.js 3.52 kB
./support-frontend/public/compiled-assets/webpack/709.js 109 kB
./support-frontend/public/compiled-assets/webpack/747.js 3.35 kB
./support-frontend/public/compiled-assets/webpack/760.js 5.8 kB
./support-frontend/public/compiled-assets/webpack/785.js 13.1 kB
./support-frontend/public/compiled-assets/webpack/8.js 20.1 kB
./support-frontend/public/compiled-assets/webpack/801.js 2.18 kB
./support-frontend/public/compiled-assets/webpack/826.js 14.6 kB
./support-frontend/public/compiled-assets/webpack/855.js 7.13 kB
./support-frontend/public/compiled-assets/webpack/916.js 8.9 kB
./support-frontend/public/compiled-assets/webpack/checkout.js 19.7 kB
./support-frontend/public/compiled-assets/webpack/GuardianAdLiteLanding.js 8.44 kB
./support-frontend/public/compiled-assets/webpack/LandingPage.js 15.9 kB
./support-frontend/public/compiled-assets/webpack/oneTimeCheckout.js 7.38 kB
./support-frontend/public/compiled-assets/webpack/StudentLandingPage.js 12.4 kB
./support-frontend/public/compiled-assets/webpack/ThankYou.js 43.7 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Jul 15, 2025

Copy link
Contributor

github-actions bot commented Jul 15, 2025

@tjmw tjmw merged commit 1c63cff into main Jul 15, 2025
18 checks passed
@tjmw tjmw deleted the tw/refactor-landing-page-e2e branch July 15, 2025 11:01
@prout-bot
Copy link

Seen on PROD (merged by @tjmw 9 minutes and 55 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants