-
Notifications
You must be signed in to change notification settings - Fork 13
Refactor landing page -> checkout e2e smoke tests #7148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+160
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call visitLandingPageAndCompleteCheckout directly from tests. The intermediate methods weren't really adding anything any more.
78f2e70
to
6bc09c6
Compare
Size Change: 0 B Total Size: 1.53 MB ℹ️ View Unchanged
|
rupertbates
approved these changes
Jul 15, 2025
Seen on PROD (merged by @tjmw 9 minutes and 55 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
This is purely a refactoring to DRY up the new e2e tests which begin on the relevant landing page and navigate through to the checkout and complete a purchase. So far this has been done for the following smoke tests:
Why are you doing this?
I noticed while working on these tests that the one piece which differed between them was transitioning from the landing page to the checkout. The rest of the work is common. The actual checkout form work continues to be done by
completeGenericCheckout
.I've added a new function
visitLandingPageAndCompleteCheckout
which does the common work, taking a callback to handle the navigation from landing page to checkout.How to test
Run the smoke tests.