-
Notifications
You must be signed in to change notification settings - Fork 13
NewPaper Plus Digital: Copy Updates #7151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Size Change: +685 B (+0.04%) Total Size: 1.53 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a few minor questions/suggestions to take or leave.
...ort-frontend/assets/pages/paper-subscription-landing/components/content/NewspaperTabHero.tsx
Outdated
Show resolved
Hide resolved
support-frontend/assets/pages/paper-subscription-landing/components/hero/hero.tsx
Outdated
Show resolved
Hide resolved
support-frontend/assets/pages/paper-subscription-landing/planData.tsx
Outdated
Show resolved
Hide resolved
…sed and seperate style and copy files added
@tjmw Think am there now, have refactored so plan to put this in tomorrow morning, just messaging in case you would like a final look through. |
support-frontend/assets/pages/paper-subscription-landing/helpers/PaperHeroCopy.tsx
Outdated
Show resolved
Hide resolved
Not code related, but it seems that we now have two sections in the card with the exact same title |
Great spot @maloky , thanks, this is not correct, fixing it now |
Seen on PROD (merged by @paul-daniel-dempsey 9 minutes and 48 seconds ago)
Sentry Release: support-client-side, support |
What are you doing in this PR?
Signed off wording: E2E Newspaper+Digital frontend journey changes
Trello Card
How to test
https://support.thegulocal.com/uk/subscribe/paper?paperProductTabs=true
Screenshots
HomeDelivery
SubscriptionCard