Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request for User#save_albums #269

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

dildal
Copy link
Contributor

@dildal dildal commented Oct 1, 2024

#268 fixes User#save_albums! {"error": {"status": 400, "message": "Missing required field: ids" } } error

@@ -394,8 +394,8 @@ def remove_albums!(albums)
def save_albums!(albums)
albums_ids = albums.map(&:id)
url = "me/albums"
request_body = albums_ids.inspect
User.oauth_put(@id, url, request_body)
request_body = { ids: tracks_ids }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dildal shouldn't it be albums_ids instead of tracks_ids?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, sloppy copy paste job 🤦

@guilhermesad guilhermesad merged commit 0ac4eb2 into guilhermesad:master Oct 3, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants