Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making rspotify @guilhermesad !
I'm using this library on a side project, and I noticed that there is something weird going on with the OAuth code. Specifically, it is defining the REST verbs once when the module is instantiated, which happens before the
@client_token
is fetched. However, the verb definitions aren't updated later when@client_token
is present, which causes all the requests to fail. I can't get it to work without this patch.Similarly, wanted to make sure that a proper error message is communicated when a
User
is instantiated without anid
(was following the comments here https://github.com/guilhermesad/rspotify#notes ).I tried to keep my changes as minimally invasive as possible, though I think there's quite a decent amount refactoring that could be done to make the code less reliant on mutable state (it's pretty confusing to read at first glance).
Let me know if you have any questions / comments please!