fix: error out for nonexistent or non-dir --venv
#30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the bin dir of a given explicit venv was simply added to `$PATH` with no checks. This may have caused unintended executables to be invoked when given a nonexistent or non-directory argument. Whatever might be in `$PATH` would have been run, with `venv-run` becoming essentially a no-op.
guludo
reviewed
Aug 28, 2023
Owner
guludo
left a comment
guludo
left a comment
There was a problem hiding this comment.
I think the rationale makes sense. Thanks.
The solution proposed with the current patch only checks for the path being a directory, but I think we could look and see that the directory looks like a virtual environment.
I'd like to suggest that we extract parts of guess() that can be reused into separate function(s) so that do can do the same type of validation when guessing and when the venv is explicitly passed via CLI. That would make the check on a explicit env consistent with the way we check when guessing.
Also, it would be good to have a test case for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the bin dir of a given explicit venv was simply added to
$PATHwith no checks.This may have caused unintended executables to be invoked when given a nonexistent or non-directory argument. Whatever might be in
$PATHwould have been run, withvenv-runbecoming essentially a no-op.