More Float to Int Casting#199
Merged
adityapatadia merged 1 commit intogumlet:masterfrom Sep 12, 2025
activated-insights:explicit-float-cast
Merged
More Float to Int Casting#199adityapatadia merged 1 commit intogumlet:masterfrom activated-insights:explicit-float-cast
adityapatadia merged 1 commit intogumlet:masterfrom
activated-insights:explicit-float-cast
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a few more less-frequent logs come through, so I figured it made sense to just cast the rest of these to integers when the function they're being passed into expects an integer.
Might as well be consistently with it throughout the file.
Current functionality casts it to an int implicitly, which cuts off the float tail. Casting it explicitly still cuts off the float tail, but avoids the warning about implicit conversion. So, the functionality will remain the same.