-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set vscode configuration up #130
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DudeBro249 , thanks for the PR! Just a few changes.
@Arnav-2004 do you think it would be worth putting a |
Yea, probably a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
how are we going to ignore use generated settings.json file? as vscode tends to generate one/users like to have one for config or is it already handled? |
@DudeBro249 I'm fine with this. If you address the feedback from and get an approval from @RohanJnr, I'll be pretty comfortable merging this. Just test it please. |
I'll remove the pip install poetry command in the task and link the poetry installation instructions in the README. |
I'll look into this. Could you clarify what you mean by this question though? |
I've tested it and it works. I'll make the necessary changes though. |
Please don't add this. I love configuring my .vscode/settings.json per project myself, and would appreciate it not being pre-configured. If we want something like this, we can store them elsewhere, and have a script to copy the files to the correct location, but please do not check files in to the repository where per-user configuration is stored. |
Note: This pull request is not trying to make all current and future contributors switch to using VSCode. It just makes it easier for developers already using VSCode to set up, develop, and run gurkbot
.vscode
entry from.gitignore
fileREADME.md
(click to view changes) with development environment setup instructions for VSCode