stalin-sort.js remade #198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Alike Array.sort(), it is now modifies the array in place. It won't be StalinSort enough, if you'd be able to bring those values back. - Sped it up. The previous version had reallocation issues, which not only were slower themself, but also led to speed losses on arrays with lots of duplicates. Now it only truncates the array once. Speed gain is 2 to hundreds times, depending on the input data, since the original algo was data-sensitive, while the new algo executes in close to only length-dependent time.
|
Hi! Thanks for your PR and sorry for the delay reviewing it. We favor having multiple implementations instead of overwriting the existing ones, can you move your implementation to a new file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alike Array.sort(), the function now modifies the array in place. It won't be StalinSort enough, if you'd be able to bring those values back.
Sped it up. The previous version had reallocation issues, which not only were slower themself, but also led to speed losses on arrays with lots of values in the resulting array (e.g. when values are already sorted or nearly-sorted, or when there are lots of duplicates). Now it only truncates the array once. Speed gain is 2 to hundreds times, depending on the input array values, since the new algo executes in close to only length-dependent time.