Merged
Conversation
|
I'm following your proposal here: https://github.com/kungfooman/worker-with-import-map/ There are two polyfills for making a |
kungfooman
reviewed
Jul 23, 2024
Comment on lines
+80
to
+81
| The proposal is to allow supporting import maps in workers, with a new `importMap` attribute for the worker instantiation options, where the | ||
| import map for the worker can be provided explicitly: |
There was a problem hiding this comment.
Inheriting the import map should be the default? That's what I expected and then went down the rabbit hole...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new proposal for worker import maps (WICG/import-maps#2), as a commonly requested feature for import maps.
The
setImportMapdesign is also described in the alternatives, but the primary proposal just describes supportingimportMapattribute option for worker construction.