Fix loglikelihood_function argument in nessai sampler

[mj-will]

Standard information about the request

This is a: bug fix

This change affects: inference

This change changes: scientific output

This change: has appropriate unit tests, follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines

This change will: fix a bug that prevents an option from being used

Motivation

The current implementation does not allow the user to specify the loglikelihood-function. Instead it raises an error:

RuntimeError: Config contains unknown options: {'loglikelihood-function'}

Contents

This happens because the sampler class checks the specified options against a list of valid options but this did not account for the pycbc-specific option loglikelihood-function. This PR adds loglikelihood-function to the set of options pycbc-specific options that are allowed.

Links to any issues or associated PRs

N/A

Testing performed

I've run the LISA injection example with a modified config where loglikelihood-function=loglr

Additional notes

• The author of this pull request confirms they will adhere to the code of conduct

[mj-will]

@HumphreyWang were you able to test this with your problem?

[GarethCabournDavies]

@mj-will what is the status of this?

[mj-will]

@GarethCabournDavies I believe this is working but @HumphreyWang should confirm. If so, then I think it is ready.