Skip to content

Conversation

aleynaakyuz
Copy link
Contributor

This raises a warning if no injections are applied during an inference job.

@ahnitz
Copy link
Member

ahnitz commented Oct 21, 2024

@aleynaakyuz I don't think this will do what you think. I think you'd only see a message if the injection-file option wasn't given. I think what you need to do is to add a logging message into the InjectionSet class itself where the injections are applied.

@ahnitz
Copy link
Member

ahnitz commented Nov 7, 2024

Think about potential changes here. https://github.com/gwastro/pycbc/blob/master/pycbc/inject/inject.py#L561

# safety buffer
start_time = inj.tc - 2 * (inj_length + 1)
if end_time < t0 or start_time > t1:
logger.warning("No injections applied.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be after the for loop?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After which loop? If there are no injections, if end_time < t0 or start_time > t1: will be True and the rest of the interaction will be skipped, right? That's why I put the warning in the loop.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's only true for a specific injection. What if the file has multiple things which could be injected? The injection file can have many signals in it (perhaps for different times or even overlapping).

@aleynaakyuz aleynaakyuz deleted the warning branch April 11, 2025 18:59
@aleynaakyuz aleynaakyuz restored the warning branch April 11, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants