Enabling onsource vs dq vetoes check in PyGRB #5022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PyGRB coherent search, the onsource and offsource trials must have the same lengths. This PR ensures that no vetoed time is included in the onsource segment, to avoid having onsource and offsource trials differing in length. If the onsource contains vetoed times, the workflow generator exits with an informative message.
Standard information about the request
This is a: new feature.
This change: has appropriate unit tests, follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
Links to any issues or associated PRs
See issue #4981
Testing performed
I took the GRB 170817A configuration file, and the workflow generation is completed. I then artificially moved the trigger time to a time with dq issues in one of the IFOs, and the workflow generation process exits in an informative way.
Additional notes