Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to remove "from xxx import *"-style imports from more places, I've used
git grep import | grep "*" | grep -v css| grep -v __init__
to find any places where this is used.I then commented out the import, ran the tests to find what needs importing and getting that explicitly (not the most sophisticated, but seems to have worked).
After this change there is now 1 place which uses "from xxx import *", which is the versioning module, and I think that is valid.
The changes are mainly in the test suite - I've tried as much as possible to get tests to now pass, using cpu and cuda schemes, as these were what was catered for before!
I'd like to have other schemes / backends working, and some cuda tests fail, but that is for another PR
Standard information about the request
This is a code quality change
This change affects: the offline search, the live search, inference, PyGRB
This change: has appropriate unit tests, follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
Motivation
#4783
Testing performed
Ran tests manually - they worked. The CI will also check this