Substituting scatterplots with hexbins where possible #5143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Addressing one of the tasks in #3660 |
| trigs[1] = numpy.array(trigs[1]) | ||
| mask = (trigs[0] >= xmin) & (trigs[0] <= xmax) | ||
| norm = matplotlib.colors.LogNorm() | ||
| gsize = 300 |
Contributor
There was a problem hiding this comment.
I think the bins are a bit too small here, isolated single triggers are hard to see. I suggest using 150 here. I also noticed the logic below to choose the bins based on the number of samples. I think if you use 150 it will be good in all cases. We can complicate the logic once we have looked at several cases later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where many points are displayed as crosses the plots become crowded. This change those scatter plots into hexbins.
This change affects: PyGRB plotting
This change changes: plotting
Please see this