Adding injections and bank corner plots to pyGRB workflows #5145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
As a broader comment, I suggest not using |
Co-authored-by: Tito Dal Canton <[email protected]>
titodalcanton
approved these changes
Sep 4, 2025
Contributor
titodalcanton
left a comment
titodalcanton
left a comment
There was a problem hiding this comment.
Thanks @MarcoCusinato this looks ready enough. Have you had a chance to test it with the latest changes?
github-project-automation
bot
moved this from In Progress
to Approved
in PyGRB Development
Contributor
Author
Not yet, but we (I) should |
Contributor
|
Note that this has a conflict now due to Thomas' recent merge. Let me know if you need help with the rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change affects: PyGRB
This change changes: result presentation / plotting
Summary:
Please see this for the current implementation.
This also addresses one of the tasks in #3660