-
Notifications
You must be signed in to change notification settings - Fork 371
Work towards removing pycbc_submit_dax
#5197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GarethCabournDavies
wants to merge
18
commits into
gwastro:master
Choose a base branch
from
GarethCabournDavies:remove_submit_dax
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Work towards removing pycbc_submit_dax
#5197
GarethCabournDavies
wants to merge
18
commits into
gwastro:master
from
GarethCabournDavies:remove_submit_dax
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
One thing to check here : do all workflows get the I have assumed that they do in the documentation changes, but I'm not 100% sure on that Edit: I think that they do, as part of the |
Contributor
Author
|
Note to self, there is a FIXME in |
Contributor
Author
|
Apart from the FIXME noted above, I think this is everything now, so removing draft status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I am working towards getting rid of
pycbc_submit_dax. I have included the commits from #4945 (so that @alishahassan gets credit).This is work in progress, but I am trying to make it so that it can be merged any time
Standard information about the request
This is the start of removing an unwanted code
This change affects: the offline search, inference, (will affect) PyGRB
This change (will) change documentation eventually
This change has been proposed using the contribution guidelines
Contents
Finding any references to
pycbc_submit_daxand fixing them as appropriate. I wanted to get the PR in sooner rather than later so that the CI tests can run nicelyLinks to any issues or associated PRs
#4945 #5080