Skip to content

Conversation

@GarethCabournDavies
Copy link
Contributor

Here I am working towards getting rid of pycbc_submit_dax. I have included the commits from #4945 (so that @alishahassan gets credit).

This is work in progress, but I am trying to make it so that it can be merged any time

Standard information about the request

This is the start of removing an unwanted code
This change affects: the offline search, inference, (will affect) PyGRB

This change (will) change documentation eventually
This change has been proposed using the contribution guidelines

Contents

Finding any references to pycbc_submit_dax and fixing them as appropriate. I wanted to get the PR in sooner rather than later so that the CI tests can run nicely

Links to any issues or associated PRs

#4945 #5080

  • The author of this pull request confirms they will adhere to the code of conduct

@GarethCabournDavies GarethCabournDavies marked this pull request as draft October 8, 2025 08:18
@GarethCabournDavies
Copy link
Contributor Author

GarethCabournDavies commented Oct 8, 2025

One thing to check here : do all workflows get the start, stop and status helper scripts made?

I have assumed that they do in the documentation changes, but I'm not 100% sure on that

Edit: I think that they do, as part of the plan_and_submit method on Workflow

@GarethCabournDavies
Copy link
Contributor Author

Note to self, there is a FIXME in pycbc/workflow/core.py:

        # FIXME: The location of output.map is hardcoded in the properties
        #        file. This is overridden for subworkflows, but is not for
        #        main workflows with submit_dax. If we ever remove submit_dax
        #        we should include the location explicitly here.

@GarethCabournDavies
Copy link
Contributor Author

Apart from the FIXME noted above, I think this is everything now, so removing draft status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants