Changes run_dir in pycbc_make_offline_grb_workflow to allow proper output-dir config #5226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added if condition for output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard information about the request
This is a bug fix for gitlab issue described here: https://git.ligo.org/pycbc/pygrb-offline-analysis/-/issues/48 wherein the method through which pycbc_make_offline_grb_workflow wrote the output directory was hard coded to be just the GRB##### tag. It will now (hopefully) be whatever is entered as the output-dir config.
This change affects: PyGRB
This change changes: directory location for PyGRB run
This change should not break current functionality
Motivation
The PyGRB search attempted to use an --output ${GRB} argument that caused issues. The name of the output directory never changed. Hopefully this solves that.
Links to any issues or associated PRs
https://git.ligo.org/pycbc/pygrb-offline-analysis/-/issues/48