Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 -- Minor change to Bullet (r,p,t => t0,p1,r2,r3,r4) #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Patch 1 -- Minor change to Bullet (r,p,t => t0,p1,r2,r3,r4) #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b32735a
changed fieldkey to include the position to be able to specify differ…
fabianvo Apr 30, 2012
c86d665
changed default tooltipValueLookups to be aligned with other change
fabianvo Apr 30, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/chart-bullet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
getCurrentRegionFields: function () {
var currentRegion = this.currentRegion;
return {
fieldkey: currentRegion.substr(0, 1),
fieldkey: currentRegion,
value: this.values[currentRegion.substr(1)],
region: currentRegion
};
Expand Down
2 changes: 1 addition & 1 deletion src/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
rangeColors: ['#d3dafe', '#a8b6ff', '#7f94ff'],
base: undefined, // set this to a number to change the base start number
tooltipFormat: new SPFormat('{{fieldkey:fields}} - {{value}}'),
tooltipValueLookups: { fields: {r: 'Range', p: 'Performance', t: 'Target'} }
tooltipValueLookups: { fields: {r4: 'Range Low', r3: 'Range Mid', r2: 'Range Max', p1: 'Performance', t0: 'Target'} }
},
// Defaults for pie charts
pie: {
Expand Down