Refactor registry key writing (#16)

gyk4j · May 14, 2024 · 4d4aa33 · 4d4aa33
1 parent 8692dc9
commit 4d4aa33
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/chcl3.cmd b/chcl3.cmd
@@ -49,19 +49,12 @@ for /f %%A IN (data\files.txt) DO (
 )
 echo.
 
-echo # Disabling Customer Experience Improvement Program (CEIP)...
-REG ADD "HKLM\SOFTWARE\Microsoft\SQMClient\Windows" /v CEIPEnable /t REG_DWORD /d 0 /f
-echo.
-
-echo # Disabling Windows Error Reporting...
-REG ADD "HKLM\SOFTWARE\Microsoft\Windows\Windows Error Reporting" /v Disabled /t REG_DWORD /d 1 /f
-REG ADD "HKLM\SOFTWARE\Microsoft\Windows\Windows Error Reporting" /v DontShowUI /t REG_DWORD /d 1 /f
-echo.
-
-echo # Disabling Windows Updates...
-REG ADD "HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdate\Auto Update" /v AUOptions /t REG_DWORD /d 1 /f
-REG ADD "HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdate\Auto Update" /v IncludeRecommendedUpdates /t REG_DWORD /d 0 /f
-REG ADD "HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdate\Auto Update" /v ElevateNonAdmins /t REG_DWORD /d 0 /f
+echo # Updating registry key values...
+for /f "delims=, tokens=1,2,3,4" %%A IN (data\registry.txt) DO (
+	ECHO [%%A]
+	ECHO %%B = %%D [%%C]
+	REG ADD "%%A" /v %%B /t %%C /d %%D /f
+)
 echo.
 
 echo # Disabling scheduled tasks...

diff --git a/data/registry.txt b/data/registry.txt
@@ -0,0 +1,6 @@
+HKLM\SOFTWARE\Microsoft\SQMClient\Windows,CEIPEnable,REG_DWORD,0
+HKLM\SOFTWARE\Microsoft\Windows\Windows Error Reporting,Disabled,REG_DWORD,1
+HKLM\SOFTWARE\Microsoft\Windows\Windows Error Reporting,DontShowUI,REG_DWORD,1
+HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdate\Auto Update,AUOptions,REG_DWORD,1
+HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdate\Auto Update,IncludeRecommendedUpdates,REG_DWORD,0
+HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdate\Auto Update,ElevateNonAdmins,REG_DWORD,0