Fix examples for crossterm on windows #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this because it's being reverted crossterm-rs/crossterm#778 |
|
@gyscos ignore the close, this is ready to be merged. It works even if the crossterm PR is merged. |
|
Thanks for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, crossterm recently added release events for windows but that means that whenever checking for events you get double of them. This breaks almost all examples.
It's actually even worse because powershell has some kind of bug where it sends a delayed release event when pressing enter in the command line, and some examples immediately close because of this.
This fixes all of that by just ignoring all release events. crossterm-rs/crossterm#745
Side note: please mention somewhere that you have to be inside the cursive/cursive folder in order to run examples with another backend, that confused me so much for a second time when using this because you get confusing errors about ncurses.