Conversation
# Conflicts: # server/Cargo.toml
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 83.15% 83.15%
=======================================
Files 16 16
Lines 285 285
=======================================
Hits 237 237
Misses 48 48 ☔ View full report in Codecov by Sentry. |
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
@l3r8yJ this file should be not pushed to the branch. Let's add it to the .gitignore
| # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| # SOFTWARE. | ||
| [package] | ||
| name = "types" |
There was a problem hiding this comment.
@l3r8yJ it's better to name package fakehub-types, instead of types. Thus we will be able to publish this package. WDYT?
| # SOFTWARE. | ||
| [package] | ||
| name = "types" | ||
| version = "0.1.0" |
| */ | ||
| /// The types. | ||
| pub mod types; | ||
| // @todo #162:25min Remove dumb documentation. |
There was a problem hiding this comment.
@l3r8yJ I think these docs is set by default for lib.rs and main.rs files, correct me if I'm wrong
| The types. | ||
| */ | ||
| /// The types. | ||
| pub mod types; |
| github-mirror/git_push.sh | ||
| github-mirror/README.md | ||
| github-mirror/.openapi-generator-ignore | ||
| github-mirror/**/src |
There was a problem hiding this comment.
@l3r8yJ we can't ignore github-mirror/src because, when we release fakehub, we package and push github-mirror to crates too
| @@ -0,0 +1,14 @@ | |||
| [package] | |||
There was a problem hiding this comment.
@l3r8yJ this should file will be autogenerated, we don't need to keep it in the repo
|
|
||
| [dependencies] | ||
| openapi = { path = "../github-mirror", version = "1.1.4" } | ||
| openapi = { path = "../github-mirror" } |
|
|
||
| /// GitHub. | ||
| #[derive(Clone)] | ||
| pub struct GitHub { |
There was a problem hiding this comment.
@l3r8yJ we have GitHub in server/objects/github.rs. We should somehow resolve ambiguity with naming here
|
@h1alexbel this PR still in WIP status, miss clicked on review button |
the POC
PR-Codex overview
This PR introduces a restructuring of the codebase, primarily focusing on the organization of modules and the addition of new dependencies, including the
kill-portpackage. It also refactors therepomodule intorepo_ops, enhancing the functionality related to repository operations.Detailed summary
kill-portdependency inpackage.jsonandpackage-lock.json.Cargo.tomlto include a newtypesmodule.repomodule torepo_opsinserver/src/objects/mod.rs.RepoOperationstrait inrepo_ops.rsfor better repo management.Repostruct intypes/src/types/repo.rs.Userstruct intypes/src/types/user.rsto includerepos.GitHubstruct intypes/src/types/github.rsfor GitHub representation.