Skip to content

Ability to specify custom highlight / unhighlight functions #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

xsustek
Copy link
Contributor

@xsustek xsustek commented Aug 26, 2024

Adds ability to specify custom highlight / unhighlight functions, defaults to original behavior and just swaps classes.

Fixes #38

@xsustek xsustek marked this pull request as ready for review August 26, 2024 10:54
Copy link
Collaborator

@dahlbyk dahlbyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@xsustek
Copy link
Contributor Author

xsustek commented Jan 3, 2025

Hi @dahlbyk, is there anything else missing or that needs to be addressed before this can be merged? Thanks.

@dahlbyk
Copy link
Collaborator

dahlbyk commented Jan 7, 2025

is there anything else missing or that needs to be addressed before this can be merged?

Nothing missing. @haacked cuts releases, but you could help him out by bumping package version to 0.11.1 and committing the result of npm run build.

@xsustek
Copy link
Contributor Author

xsustek commented Jan 8, 2025

is there anything else missing or that needs to be addressed before this can be merged?

Nothing missing. @haacked cuts releases, but you could help him out by bumping package version to 0.11.1 and committing the result of npm run build.

Done

@haacked haacked merged commit d90831e into haacked:main Jan 14, 2025
1 check passed
@haacked
Copy link
Owner

haacked commented Jan 14, 2025

Sorry for the delay! Started a new job and have been pretty busy. 😄

@haacked
Copy link
Owner

haacked commented Jan 14, 2025

It's live on NPM! https://www.npmjs.com/package/aspnet-client-validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding highlight/unhighlight events
3 participants