Starts implementation for --force system & establishes naming consistency #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh hrm this doesn't look good. |
|
Okay it seems to be having problems with paths |
grymmy
approved these changes
May 6, 2024
There was a problem hiding this comment.
I'm fine w/ this landing but would note that the sync and sync-force workflows could, instead of being carbon copies of each other, be shared and extended via decoration using the github reusable workflow pattern. This would result in reduced LOC and ensure these workflows are kept in sync over time as changes are needed in one or the other.
|
Oh interesting I wasn't aware of that. Will implement! |
|
@jaspermayone just ping me when u want re-review |
Muirrum
approved these changes
May 10, 2024
|
Docs on --force here octodns/octodns#1170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts the implementation for a
--forcesystem as well as establishing some constancy for workflow/file naming.See https://hackclub.slack.com/archives/C05SVRTCDGV/p1714867674790609?thread_ts=1714613706.014109&cid=C05SVRTCDGV for why the validation flow is currently blocked, but this PR will at least establish a manual workflow unblocking the other PR's, until we establish an auto labeler / system.