Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding archives.hackclub.com #1386

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding archives.hackclub.com #1386

wants to merge 2 commits into from

Conversation

crabby605
Copy link

Adding archives.hackclub.com

Description

this subdomain will be used for storing all the leader newsletters

@crabby605 crabby605 requested review from a team as code owners October 29, 2024 08:29
@cytronicoder
Copy link
Member

what does this mean?

@crabby605
Copy link
Author

what does this mean?

I'm trying to revive the leader newsletter archive with @JaredSene so I wanted a subdomain for it

Copy link
Member

@alx-alexpark alx-alexpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort alphabetically within the file. Also, waiting on HQ approval.

@crabby605
Copy link
Author

Please sort alphabetically within the file. Also, waiting on HQ approval.

I need HQ approval?? I had asked Jared though?

@crabby605
Copy link
Author

Please sort alphabetically within the file. Also, waiting on HQ approval.

I need HQ approval?? I had asked Jared though?

But not for the subdomain if that's something I'm not supposed to do then close this PR

@alx-alexpark
Copy link
Member

Holding, pending approval

@crabby605
Copy link
Author

Holding, pending approval

Approval yet?

archives:
- ttl: 600
type: CNAME
value: crabby605.github.io.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is an official HQ project, I'd prefer to see it in the hackclub/ namespace

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting on an approval!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants