Add joined_as_teenager to User
#12607
Conversation
|
making birthday encrypted strikes again smh |
Co-authored-by: Gary Tou <gary@garytou.com>
|
Once the other PR merges, there will be a conflict here. Fix that and then this will be good to merge! |
|
We'll need to backfill |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
There was a problem hiding this comment.
This is structured different than the UpdateTeenagerColumnJob but I think it should still work.
| include HasTasks | ||
|
|
||
| before_update { self.teenager = teenager? } | ||
| before_update { self.joined_as_teenager = joined_as_teenager? } |
There was a problem hiding this comment.
| before_update { self.joined_as_teenager = joined_as_teenager? } | |
| before_update(if: :will_save_change_to_birthday?) { self.joined_as_teenager = joined_as_teenager? } |
Double check my code, but this may be what you want.
| def joined_as_teenager? | ||
| age_on(created_at)&.<=(18) | ||
| end | ||
|
|
There was a problem hiding this comment.
This will end up clashing with the joined_as_teenager? defined by Rails pulling from the database. Should we call this something else so that we pull from the DB when possible?
There was a problem hiding this comment.
Gary and I discussed this and I think we're going to loop back to fix this as it also affects teenager?
This allows us to get a more accurate count on referrals