Skip to content

Conversation

@YodaLightsabr
Copy link
Contributor

Summary of the problem

Previously, card grants wouldn't automatically inherit pre-authorization settings (you needed to check the box each time)

Describe your changes

This PR now properly inherits the value when creating a new card grant

@YodaLightsabr YodaLightsabr requested a review from a team January 15, 2026 01:21
@garyhtou
Copy link
Member

can you please check Slack? lol

Copy link
Member

@sampoder sampoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use set_defaults?

@YodaLightsabr
Copy link
Contributor Author

@sampoder set_defaults runs before_create, and we need these attributes to be set so that they can be configured per-grant on the create form

@sampoder
Copy link
Member

Maybe we should do something like this: https://stackoverflow.com/a/10061330? It feels odd for this to be in the controller imo

@YodaLightsabr
Copy link
Contributor Author

Should we move the invite message there, too? That way instead of a blank message defaulting to the org-level message, it prefills the org-level message and lets you customize it

@sampoder
Copy link
Member

Should we move the invite message there, too? That way instead of a blank message defaulting to the org-level message, it prefills the org-level message and lets you customize it

yes imo - good idea

Copy link
Member

@sampoder sampoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants