-
Notifications
You must be signed in to change notification settings - Fork 85
[Card Grants] Inherit pre-authorization setting by default #12644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
can you please check Slack? lol |
sampoder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use set_defaults?
|
@sampoder |
|
Maybe we should do something like this: https://stackoverflow.com/a/10061330? It feels odd for this to be in the controller imo |
|
Should we move the invite message there, too? That way instead of a blank message defaulting to the org-level message, it prefills the org-level message and lets you customize it |
yes imo - good idea |
sampoder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thank you!
Summary of the problem
Previously, card grants wouldn't automatically inherit pre-authorization settings (you needed to check the box each time)
Describe your changes
This PR now properly inherits the value when creating a new card grant