[Receipts] Add button to copy receipt email on transaction partial #12699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
app/views/canonical_pending_transactions/_canonical_pending_transaction.html.erb
Outdated
Show resolved
Hide resolved
app/views/canonical_transactions/_canonical_transaction.html.erb
Outdated
Show resolved
Hide resolved
Contributor
|
oh my gosh i have been wanting this feature for ages. if you could enable this on my account id be eternally grateful! |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ansaction.html.erb Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
polypixeldev
left a comment
polypixeldev
left a comment
There was a problem hiding this comment.
Looks nice, if this is ends up automatically enabled for people I would change the tooltip text to be more descriptive about what the email is
app/views/canonical_pending_transactions/_canonical_pending_transaction.html.erb
Outdated
Show resolved
Hide resolved
app/views/canonical_transactions/_canonical_transaction.html.erb
Outdated
Show resolved
Hide resolved
Co-authored-by: Samuel Fernandez <me@sfernandez.dev>
Member
|
this is cool - what does the UI look like? |
Contributor
Author
|
@sampoder Just updated the PR description |
Co-authored-by: Samuel Fernandez <me@sfernandez.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
It'd be nifty if you could, in 1 click, copy the email address to upload receipts on a transaction. I put this together in 10 minutes as an experiment, and I put it behind a Flipper flag to allow us to do some internal testing with power users. Ideas / feedback welcome & encouraged.
Note: the tooltip has since changed. It now reads "Copy email address to clipboard to send receipts to this this transaction"