change the structure of _SeafDirentBase #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I did some changes in _SeafDirentBase class
I think we dont need self.client attribute cause it exists already in self.repo
path of return object could be defined by adding '/' + name
we need to add some new attributes in this class:
Otherwise, I think it's is more useful if we place _get_upload_link in _SeafDirentBase instead if SeafDir. Cause in some situations, I want to request the upload link from a file which i was changing it and then upload it back to seafile server.
I'm sorry if you have some confuses cause English is not my mother tongue. Hit me back and thank for reviewing my code