Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the structure of _SeafDirentBase #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nguacon01
Copy link

Hello,
I did some changes in _SeafDirentBase class
I think we dont need self.client attribute cause it exists already in self.repo
path of return object could be defined by adding '/' + name
we need to add some new attributes in this class:

  • parent_dir: path of upstream directory
  • I added attr 'type' and it must be 'dir' or 'file' instead of using isdir attribute like you did
  • I think we need fullpath attribute of object for upload file stubs

Otherwise, I think it's is more useful if we place _get_upload_link in _SeafDirentBase instead if SeafDir. Cause in some situations, I want to request the upload link from a file which i was changing it and then upload it back to seafile server.

I'm sorry if you have some confuses cause English is not my mother tongue. Hit me back and thank for reviewing my code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant