Check if file or dir is .. #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killing
reviewed
Oct 31, 2024
server/repo-mgr.c
Outdated
| file_name = components[j]; | ||
| if (g_strcmp0(file_name, "..") == 0) { | ||
| g_strfreev (components); | ||
| seaf_warning ("File or dir name is .., skip.\n"); |
common/rpc-service.c
Outdated
| @@ -2387,6 +2387,11 @@ seafile_post_file (const char *repo_id, const char *temp_file_path, | |||
| return -1; | |||
| } | |||
|
|
|||
| if (g_strcmp0(file_name, "..") == 0) { | |||
There was a problem hiding this comment.
看了一下，rpc 和文件上传的 API，最终都会调用 should_ignore_file() 来检查文件名的合法性的，所以这些检查都不需要了。
killing
reviewed
Oct 31, 2024
| } | ||
| if entry.NewName == "" && shouldIgnore(entry.Name) { | ||
| return true | ||
| } |
There was a problem hiding this comment.
如果是 rename 事件，那么不用检查 Name 字段了，只需要检查 NewName。另外，上面的代码第二个 if 写错了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.