Correct prefix measurement logic in FormattedList #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix measurement of prefix placeables by using the given constraints.
Owner
|
Thanks for the contribution |
Contributor
Author
|
Hello, any idea of when you would be able to make a new release of the library ? Thanks in advance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix measurement of prefix placeables by using the given constraints. Using new constraints could create UI issues when adding an height constraint on the RichText composable.
This can easily be reproduced using the sample app and adding
.heightIn(max = 150.dp)at line 129. Without the correction, the prefixes are drawn even if the corresponding item is out of the view.