Validate C3DFile before writing #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move label uniqueness and deduplication checks from validation stage to C3DFile constructor. - Add warning when duplicate labels are renamed
- Add immediate validation to verify group uniqueness
- Add validation to enforce parameter uniqueness
- Needed `==` and `hash` functions for `Parameter`
- Required adding a kwarg to `readc3d` (explained in docstring)
- Validation test needed update due to above changes
…and as-written parameters
(Any added groups or parameters are required by the spec and/or to read properly, therefore the original group/parameter being missing is incorrect and the "difference" of the added group/parameter is correct/more proper)
… when relevant (The parameter write function is only designed for allowed scalar types and is incorrect otherwise)
…ro if calculated AND valid
Large number of channels may overflow into an ANALOG:SCALE2, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
validatefunction modified groups and parameters to be consistent/correct for creating the Julia C3DFile object. This is problematic where certain Julia requirements are stricter than the C3D file spec (e.g. labels need not be unique, but Dict keys must be) and the validation resulted in loss of the as-read data.This PR generally cleans things up and reduces differences between the original .c3d and the .c3d written by C3D.jl.