Skip to content

Support batch enabling and disabling of users #7631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DeliciousYellow
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

支持批量启用或批量禁用用户

Which issue(s) this PR fixes:

#7557

Fixes #7557

Special notes for your reviewer:

我的第一个pr,请多指教

Does this PR introduce a user-facing change?

支持批量启用或批量禁用用户

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 15, 2025
@CLAassistant
Copy link

CLAassistant commented Jul 15, 2025

CLA assistant check
All committers have signed the CLA.

@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby July 15, 2025 13:18
Copy link

f2c-ci-robot bot commented Jul 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign guqing for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献,以下是一些建议。

@DeliciousYellow DeliciousYellow requested a review from ruibaby July 16, 2025 13:29
@DeliciousYellow
Copy link
Contributor Author

@ruibaby 已根据建议修改完成,请帮忙复查,感谢

@ruibaby ruibaby changed the title Support batch enable and disable Support batch enabling and disabling of users Jul 17, 2025
2.使判断当前user启停用状态时条件更加宽松,以解决新增用户后该属性undefined而被过滤的问题。(之前测试时用的数据是之前构建并使用过单独启\禁用的)
Copy link

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

感谢贡献👍

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.65%. Comparing base (42c374d) to head (91aecec).
Report is 102 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7631      +/-   ##
============================================
+ Coverage     59.55%   59.65%   +0.09%     
+ Complexity     3812     3789      -23     
============================================
  Files           677      676       -1     
  Lines         23248    23097     -151     
  Branches       1500     1483      -17     
============================================
- Hits          13846    13778      -68     
+ Misses         8764     8683      -81     
+ Partials        638      636       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ruibaby ruibaby merged commit 5bb7b28 into halo-dev:main Jul 18, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持批量启用、禁用用户
3 participants