-
-
Notifications
You must be signed in to change notification settings - Fork 10k
Support batch enabling and disabling of users #7631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support batch enabling and disabling of users #7631
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感谢贡献,以下是一些建议。
Co-authored-by: Ryan Wang <[email protected]>
Co-authored-by: Ryan Wang <[email protected]>
Co-authored-by: Ryan Wang <[email protected]>
Co-authored-by: Ryan Wang <[email protected]>
Co-authored-by: Ryan Wang <[email protected]>
…disable' into feature/support-batch-enable-or-disable
@ruibaby 已根据建议修改完成,请帮忙复查,感谢 |
2.使判断当前user启停用状态时条件更加宽松,以解决新增用户后该属性undefined而被过滤的问题。(之前测试时用的数据是之前构建并使用过单独启\禁用的)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
感谢贡献👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7631 +/- ##
============================================
+ Coverage 59.55% 59.65% +0.09%
+ Complexity 3812 3789 -23
============================================
Files 677 676 -1
Lines 23248 23097 -151
Branches 1500 1483 -17
============================================
- Hits 13846 13778 -68
+ Misses 8764 8683 -81
+ Partials 638 636 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
支持批量启用或批量禁用用户
Which issue(s) this PR fixes:
#7557
Fixes #7557
Special notes for your reviewer:
我的第一个pr,请多指教
Does this PR introduce a user-facing change?