-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PluginLoader class #9
Conversation
This kind of "iterate over the plugins" could probably be factored. Refs hamperbot#7.
Not sure if this works for quotes, since that plugin appears to not register commands correctly. What is up with that? Refs hamperbot#7.
And update the plugin plugins to match. ...At some point, "plugin" starts to look like a very funny word. Refs hamperbot#7.
At this point, we've pulled everything out. All that remains is to unknot some of the execution. Refs hamperbot#7.
@@ -218,6 +193,39 @@ def clientConnectionFailed(self, connector, reason): | |||
print "Could not connect: %s" % (reason,) | |||
|
|||
def registerPlugin(self, plugin): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is almost completely unused now, only the CommanderFactor still uses it, and then the change should be trivial. Nix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed; patch incoming.
One small issue I ran into:
This and the nit I had above are the only issues I see. |
Remember, kids, don't code while tired. Refs hamperbot#7.
And fix its only use. Refs hamperbot#7.
Separate plugin loader from commander. Thanks Corbin!
Factor out plugin loading and unloading, and general plugin management, to its own class. This is the first part of #7; this factoring has to happen before any alternative interaction with Hamper can be set up.