Update multiple halo2 user phases handling logic #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
plonkishsupports proving the halo2 circuit with multiple user phases partially. In this PR, I am trying to fix some subtle mistake & add support for multi-phase witness assignment.PlonkishCircuitInfostruct'snum_challengesfield has subtle mistake, if the last phase does not squeeze out challenges, then the length ofnum_challengesandnum_witness_polyswill mismatch, leading to the failure in line. It can be worked around by simply adding0if there is no challenge in the last phase.column_idxhash map key does not contain the column phase information.num_witness_polys[phase]amount of advice columns around, so the cell in the previous phase column cannot be assigned to the next phase column. It's quite trivial to allow cell copy from the previous phase to the next phase column, but the other way should be prohibited.