fix JakeWharton#380 Quick-Fix incorrectly applied in kotlin

hannesa2 · Aug 11, 2021 · fadd335 · fadd335
1 parent c00ef8a
commit fadd335
Showing 1 changed file with 93 additions and 0 deletions.
diff --git a/timber-lint/src/test/java/timber/lint/WrongTimberUsageDetectorTest.kt b/timber-lint/src/test/java/timber/lint/WrongTimberUsageDetectorTest.kt
@@ -69,6 +69,34 @@ class WrongTimberUsageDetectorTest {
             |-     Log.d("TAG", "msg")
             |+     Timber.d("msg")
             |""".trimMargin())
+
+    lint()
+        .files(
+            kt("""
+                |package foo
+                |import android.util.Log
+                |class Example {
+                |  fun log() {
+                |    Log.d("TAG", "msg")
+                |  }
+                |}""".trimMargin())
+        )
+        .issues(WrongTimberUsageDetector.ISSUE_LOG)
+        .run()
+        .expect("""
+            |src/foo/Example.kt:5: Warning: Using 'Log' instead of 'Timber' [LogNotTimber]
+            |    Log.d("TAG", "msg")
+            |    ~~~~~~~~~~~~~~~~~~~
+            |0 errors, 1 warnings""".trimMargin())
+        .expectFixDiffs("""
+            |Fix for src/foo/Example.kt line 5: Replace with Timber.tag("TAG").d("msg"):
+            |@@ -5 +5
+            |-     Log.d("TAG", "msg")
+            |+     Timber.tag("TAG").d("msg")
+            |Fix for src/foo/Example.kt line 5: Replace with Timber.d("msg"):
+            |@@ -5 +5
+            |-     Log.d("TAG", "msg")
+            |+     Timber.d("msg")""".trimMargin())
   }
 
   @Test fun usingAndroidLogWithThreeArguments() {
@@ -119,6 +147,25 @@ class WrongTimberUsageDetectorTest {
             |-     Log.d("TAG", "msg", Exception())
             |+     Timber.d(Exception(), "msg")
             |""".trimMargin())
+
+    lint()
+        .files(
+            kt("""
+                |package foo
+                |import android.util.Log
+                |class Example {
+                |  fun log() {
+                |    Log.d("TAG", "msg", Exception())
+                |  }
+                |}""".trimMargin())
+        )
+        .issues(WrongTimberUsageDetector.ISSUE_LOG)
+        .run()
+        .expect("""
+            |src/foo/Example.kt:5: Warning: Using 'Log' instead of 'Timber' [LogNotTimber]
+            |    Log.d("TAG", "msg", Exception())
+            |    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+            |0 errors, 1 warnings""".trimMargin())
   }
 
   @Test fun usingFullyQualifiedAndroidLogWithTwoArguments() {
@@ -167,6 +214,34 @@ class WrongTimberUsageDetectorTest {
             |-     android.util.Log.d("TAG", "msg")
             |+     Timber.d("msg")
             |""".trimMargin())
+
+    lint()
+        .files(
+            kt("""
+                |package foo
+                |class Example {
+                |  fun log() {
+                |    android.util.Log.d("TAG", "msg")
+                |  }
+                |}""".trimMargin())
+        )
+        .issues(WrongTimberUsageDetector.ISSUE_LOG)
+        .run()
+        .expect("""
+            |src/foo/Example.kt:4: Warning: Using 'Log' instead of 'Timber' [LogNotTimber]
+            |    android.util.Log.d("TAG", "msg")
+            |    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+            |0 errors, 1 warnings""".trimMargin())
+        .expectFixDiffs("""
+            |Fix for src/foo/Example.kt line 4: Replace with Timber.tag("TAG").d("msg"):
+            |@@ -4 +4
+            |-     android.util.Log.d("TAG", "msg")
+            |+     Timber.tag("TAG").d("msg")
+            |Fix for src/foo/Example.kt line 4: Replace with Timber.d("msg"):
+            |@@ -4 +4
+            |-     android.util.Log.d("TAG", "msg")
+            |+     Timber.d("msg")
+            |""".trimMargin())
   }
 
   @Test fun usingFullyQualifiedAndroidLogWithThreeArguments() {
@@ -215,6 +290,24 @@ class WrongTimberUsageDetectorTest {
             |-     android.util.Log.d("TAG", "msg", Exception())
             |+     Timber.d(Exception(), "msg")
             |""".trimMargin())
+
+    lint()
+        .files(
+            kt("""
+                |package foo
+                |class Example {
+                |  fun log() {
+                |    android.util.Log.d("TAG", "msg", Exception());
+                |  }
+                |}""".trimMargin())
+        )
+        .issues(WrongTimberUsageDetector.ISSUE_LOG)
+        .run()
+        .expect("""
+            |src/foo/Example.kt:4: Warning: Using 'Log' instead of 'Timber' [LogNotTimber]
+            |    android.util.Log.d("TAG", "msg", Exception());
+            |    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+            |0 errors, 1 warnings""".trimMargin())
   }
 
   @Test fun innerStringFormat() {