-
-
Notifications
You must be signed in to change notification settings - Fork 253
Fix: Reforge modifiers from NEU repo #4524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lunaynx
wants to merge
10
commits into
hannibal002:beta
Choose a base branch
from
lunaynx:fix/reforge-nbt-modifier
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
2 Detekt FailuresRules flagged (2):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
What
Use the NEU repo to get the correct value for the
modifier
NBT tag of reforges where available. The PR above specifies it for any case that has even a slight chance of being ambiguous, but our fallback parsing here is a little smarter and can infer some of those automatically.Changelog Fixes
Changelog Technical Details
ItemStack.getReforgeName()
toItemStack.getReforgeModifier()
. - LunaReforgeApi.nonePowerStoneReforge
toReforgeApi.basicReforgeList
. - LunaReforgeApi.onlyPowerStoneReforge
toReforgeApi.reforgeStoneList
. - Luna