Skip to content

Fix: Reforge modifiers from NEU repo #4524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: beta
Choose a base branch
from

Conversation

lunaynx
Copy link
Contributor

@lunaynx lunaynx commented Jul 30, 2025

Dependencies

What

Use the NEU repo to get the correct value for the modifier NBT tag of reforges where available. The PR above specifies it for any case that has even a slight chance of being ambiguous, but our fallback parsing here is a little smarter and can infer some of those automatically.

Changelog Fixes

  • Fixed some reforges not being detected in Estimated Item Value and Reforge Overlay. - Luna

Changelog Technical Details

  • Renamed ItemStack.getReforgeName() to ItemStack.getReforgeModifier(). - Luna
  • Renamed ReforgeApi.nonePowerStoneReforge to ReforgeApi.basicReforgeList. - Luna
  • Renamed ReforgeApi.onlyPowerStoneReforge to ReforgeApi.reforgeStoneList. - Luna

@github-actions github-actions bot added Bug Fix Bug fixes Waiting on Dependency PR waiting for a dependency pr to be merged labels Jul 30, 2025
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Jul 30, 2025
Copy link

I have detected some issues with your pull request:

Body issues:
Author is not set in text: + Renamed ItemStack.getReforgeName()toItemStack.getReforgeModifier().
Unexpected empty line after category declared

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Jul 30, 2025
@github-actions github-actions bot added Fails Multi-Version A pr that fails build multiversion Detekt Has detekt problem and removed Fails Multi-Version A pr that fails build multiversion labels Jul 30, 2025
Copy link

2 Detekt Failures

Rules flagged (2): LongMethod, NoUnusedImports

@github-actions github-actions bot removed the Detekt Has detekt problem label Jul 30, 2025
@hannibal002 hannibal002 added this to the 5.0.0 milestone Jul 30, 2025
@lunaynx lunaynx changed the title Fix: Use nbtModifier from NEU repo for reforges Fix: Reforge modifiers from NEU repo Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Bug fixes Waiting on Dependency PR waiting for a dependency pr to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants