Feat/extra resource loading from npm #784

jkiddo · 2025-02-23T15:04:32Z

This feature is backwards compatible and introduces the option to load e.g. example packages from IG's based on configuration

jamesagnew · 2025-02-23T22:28:35Z

This functionality would probably make sense to just roll into the base PackageInstallationSpec. I'd rather not have this project implementing novel features not actually found in the base project, that's hard for support.

# Conflicts: # src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java

…dition Added try-load of HAPI optimized dialect

jkiddo · 2025-02-24T20:08:24Z

Sure ... I can make a PR to the base getting the additionalResourceFolders added the PackageInstallationSpec.

jkiddo · 2025-02-24T20:11:29Z

@jamesagnew whats your take on the refactored version of the PostConstruct I've done here in https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/784/files#diff-0f42a12718125be49d417ad9c402f5f2cecddfb7cb0ecfde364ad09132fa2a99R21 as mentioned in #758

jkiddo · 2025-02-24T20:14:12Z

and btw - the same thing I did on https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/784/files#diff-cca286d85a1c14aea8b529430ecd47aa4a803b53f4c7816deb7d602bd2af3268R11 can be done for a loooooong range of interceptor logic currently handled in the already way-too-big

hapi-fhir-jpaserver-starter/src/main/java/ca/uhn/fhir/jpa/starter/common/StarterJpaConfig.java

Line 262 in 792f520

public RestfulServer restfulServer(

method (I'm not pointing fingers here as I most likely authored a lot of it myself).

jkiddo · 2025-02-27T10:55:44Z

@jamesagnew I'll move the additional sources logic once its been merged in here - acceptable for you? Then we can merge this into #785 and remove it from the starter as soon as it can be resolved from a snapshot in core.

# Conflicts: # src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java

jkiddo · 2025-03-14T20:13:21Z

@jamesagnew / @dotasek - I've isolated the feature set now into hapifhir/hapi-fhir#6802. Let me know if thats the feature set you had in mind, before I start writing tests and all.

Copilot

Pull Request Overview

This PR implements the capability to load additional resources from npm packages through configuration while maintaining backwards compatibility. The key changes include:

Updating the YAML configuration to support additional resource folders for integration guides.
Introducing ExtendedPackageInstallationSpec and AdditionalResourceInstaller to process and install extra resources.
Integrating the new resource installation flow in StarterJpaConfig and updating AppProperties accordingly.

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/main/resources/application.yaml	Updated IG configuration comments to include additionalResourceFolders support.
src/main/java/ca/uhn/fhir/jpa/starter/util/JpaHibernatePropertiesProvider.java	Added logger and refactored dialect resolution for an optimized HAPI dialect.
src/main/java/ca/uhn/fhir/jpa/starter/ig/ExtendedPackageInstallationSpec.java	Added additionalResourceFolders support in IG package installation spec.
src/main/java/ca/uhn/fhir/jpa/starter/ig/AdditionalResourceInstaller.java	Introduced a new service to collect and install extra resources from npm packages.
src/main/java/ca/uhn/fhir/jpa/starter/common/StarterJpaConfig.java	Integrated additional resource installation in the package installer flow.
src/main/java/ca/uhn/fhir/jpa/starter/common/PartitionModeConfigurer.java	Refactored dependency injection implementation.
src/main/java/ca/uhn/fhir/jpa/starter/common/OnPartitionModeEnabled.java	Added conditional configuration for partition mode support.
src/main/java/ca/uhn/fhir/jpa/starter/common/FhirServerConfigCommon.java	Removed redundant PartitionModeConfigurer bean registration.
src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java	Updated properties to support extended IG installation specs and additional resource configuration.

Files not reviewed (1)

Dockerfile: Language not supported

src/main/java/ca/uhn/fhir/jpa/starter/util/JpaHibernatePropertiesProvider.java

Copilot · 2025-04-29T07:39:11Z

src/main/java/ca/uhn/fhir/jpa/starter/ig/AdditionalResourceInstaller.java

+					.map(fileName -> {
+						try {
+							return new String(folder.fetchFile(fileName));
+						} catch (IOException e) {


Consider logging the complete exception details in the catch block when fetching file contents fails, to improve debugging of resource loading issues.

Suggested change

} catch (IOException e) {

} catch (IOException e) {

logger.error("Failed to fetch file '{}' from folder '{}'.", fileName, folder.getPath(), e);

* Added reusable feature set from hapifhir/hapi-fhir-jpaserver-starter#784 * Added a few sanity tests * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/packages/PackageInstallationSpec.java Co-authored-by: tadgh <[email protected]> * Addressed most comments * Reduced package size and added exception * Added changelog --------- Co-authored-by: tadgh <[email protected]>

# Conflicts: # src/main/resources/application.yaml

robogary · 2025-05-07T18:58:52Z

Formatting check succeeded!

robogary · 2025-05-25T09:39:25Z

Formatting check succeeded!

Addling the binary content as its needed for example resource inspection

robogary · 2025-05-26T07:29:50Z

Formatting check succeeded!

…iesProvider.java Co-authored-by: Copilot <[email protected]>

# Conflicts: # pom.xml

robogary · 2025-06-05T20:58:36Z

Formatting check succeeded!

robogary · 2025-06-05T21:05:12Z

Formatting check succeeded!

jkiddo · 2025-06-05T21:07:06Z

@dotasek once 8.4 is out the door this should be good to go.

jkiddo added 4 commits February 21, 2025 22:49

Logic to do the basics

130b6ba

Added configurable folders

926cc95

Scoped additional resources to - pr. IG

2e294d8

Updated telemetry version

36202d8

jkiddo added 3 commits February 24, 2025 09:10

Changed to set

4b509a8

Merge branch 'hapi-master' into feat/extra-resource-loading-from-npm

578ee8b

# Conflicts: # src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java

Changed PostConstruct to Component and introduced use of PartitionCon…

e6b4866

…dition Added try-load of HAPI optimized dialect

Satisfying spotless

8fafde9

jkiddo marked this pull request as ready for review February 25, 2025 07:56

jkiddo requested a review from dotasek February 25, 2025 07:56

jkiddo added 4 commits February 27, 2025 13:00

Reverted to default config

dea6fc6

Merge branch 'hapi-master' into feat/extra-resource-loading-from-npm

224b2bd

# Conflicts: # src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java

Apply spotless

bad73a5

Merge branch 'master' into feat/extra-resource-loading-from-npm

99e76ae

# Conflicts: # src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java

jkiddo added a commit to jkiddo/hapi-fhir that referenced this pull request Mar 14, 2025

Added reusable feature set from hapifhir/hapi-fhir-jpaserver-starter#784

81d0811

jkiddo mentioned this pull request Mar 19, 2025

Feat/additional folder options hapifhir/hapi-fhir#6802

Merged

Merge branch 'hapifhir:master' into feat/extra-resource-loading-from-npm

5e81861

jkiddo requested a review from Copilot April 29, 2025 07:38

Copilot AI reviewed Apr 29, 2025

View reviewed changes

Merge branch 'hapi-master' into feat/extra-resource-loading-from-npm

3206140

# Conflicts: # src/main/resources/application.yaml

Merge branch 'hapifhir:master' into feat/extra-resource-loading-from-npm

ba8b38e

jkiddo marked this pull request as draft May 26, 2025 06:57

Use core-provided feature

b2e4d61

Addling the binary content as its needed for example resource inspection

jkiddo and others added 2 commits May 26, 2025 10:06

Update src/main/java/ca/uhn/fhir/jpa/starter/util/JpaHibernatePropert…

c9d2aaf

…iesProvider.java Co-authored-by: Copilot <[email protected]>

Merge branch 'master' into feat/extra-resource-loading-from-npm

3149a6a

# Conflicts: # pom.xml

Reverting dialect change - fit for a potential other PR

0e75261

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat/extra resource loading from npm #784

Feat/extra resource loading from npm #784

Uh oh!

jkiddo commented Feb 23, 2025

Uh oh!

jamesagnew commented Feb 23, 2025

Uh oh!

jkiddo commented Feb 24, 2025

Uh oh!

jkiddo commented Feb 24, 2025

Uh oh!

jkiddo commented Feb 24, 2025

Uh oh!

jkiddo commented Feb 27, 2025

Uh oh!

jkiddo commented Mar 14, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Apr 29, 2025

Uh oh!

robogary commented May 7, 2025

Uh oh!

robogary commented May 25, 2025

Uh oh!

robogary commented May 26, 2025

Uh oh!

robogary commented Jun 5, 2025

Uh oh!

robogary commented Jun 5, 2025

Uh oh!

jkiddo commented Jun 5, 2025

Uh oh!

Uh oh!

	} catch (IOException e) {
	} catch (IOException e) {
	logger.error("Failed to fetch file '{}' from folder '{}'.", fileName, folder.getPath(), e);

Feat/extra resource loading from npm #784

Are you sure you want to change the base?

Feat/extra resource loading from npm #784

Uh oh!

Conversation

jkiddo commented Feb 23, 2025

Uh oh!

jamesagnew commented Feb 23, 2025

Uh oh!

jkiddo commented Feb 24, 2025

Uh oh!

jkiddo commented Feb 24, 2025

Uh oh!

jkiddo commented Feb 24, 2025

Uh oh!

jkiddo commented Feb 27, 2025

Uh oh!

jkiddo commented Mar 14, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

robogary commented May 7, 2025

Uh oh!

robogary commented May 25, 2025

Uh oh!

robogary commented May 26, 2025

Uh oh!

robogary commented Jun 5, 2025

Uh oh!

robogary commented Jun 5, 2025

Uh oh!

jkiddo commented Jun 5, 2025

Uh oh!

Uh oh!