Skip to content

Added support for hybrid remote terminology #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

jkiddo
Copy link
Collaborator

@jkiddo jkiddo commented Mar 19, 2025

No description provided.

@jkiddo jkiddo marked this pull request as ready for review March 26, 2025 22:20
@tadgh
Copy link
Collaborator

tadgh commented Mar 31, 2025

Formatting check succeeded!

@jkiddo jkiddo requested a review from Copilot April 28, 2025 17:35
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces support for hybrid remote terminology services by adding new configuration properties, validation tests, and bean registration to integrate remote terminology services. Key changes include updating integration tests to validate remote terminology functionality, adding new YAML configuration entries for SNOMED and LOINC, and registering a new bean in the server configuration that adds remote terminology validation support.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/test/java/ca/uhn/fhir/jpa/starter/ExampleServerR4IT.java Updated test configuration and added a new test to validate remote terminology services.
src/main/resources/application.yaml Introduced remote terminology service configuration for SNOMED and LOINC.
src/main/java/ca/uhn/fhir/jpa/starter/common/validation/OnRemoteTerminologyPresent.java Added a condition class to check for the presence of remote terminology configurations.
src/main/java/ca/uhn/fhir/jpa/starter/common/FhirServerConfigR4.java Registered a new bean to integrate remote terminology validation support based on configuration.
src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java Added a new property and nested class to hold remote terminology service details.

@robogary
Copy link

Formatting check succeeded!

…api-fhir-jpaserver-starter into feat/remote-terminology-support
@patrick-werner
Copy link
Member

I created #810 to be able to see why the smoke test fails

@robogary
Copy link

Formatting check succeeded!

jkiddo added 2 commits April 29, 2025 13:22
…api-fhir-jpaserver-starter into feat/remote-terminology-support
@robogary
Copy link

Formatting check succeeded!

@robogary
Copy link

robogary commented May 1, 2025

Formatting check succeeded!

@jkiddo
Copy link
Collaborator Author

jkiddo commented May 1, 2025

@patrick-werner I don't got much more insights from the extra logging files you added, I'm afraid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants