Skip to content

feature: added patientMergeProvider config option #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

patrick-werner
Copy link
Member

fix: removing duplicated bulk_export_enabled yaml entry

fix: removing duplicated bulk_export_enabled yaml entry
@robogary
Copy link

This Pull Request has failed the formatting check

Please run mvn spotless:apply or mvn clean install -DskipTests to fix the formatting issues.

You can automate this auto-formatting process to execute on the git pre-push hook, by installing pre-commit and then calling pre-commit install --hook-type pre-push. This will cause formatting to run automatically whenever you push.

@patrick-werner patrick-werner requested a review from Copilot April 10, 2025 16:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java:482

  • [nitpick] Consider renaming the getter to isPatient_merge_enabled() to follow JavaBean naming conventions for boolean properties.
public boolean getPatient_merge_enabled() {

src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java:486

  • [nitpick] Consider aligning the setter parameter type with the field type, using 'boolean' instead of 'Boolean' for consistency.
public void setPatient_merge_enabled(Boolean patient_merge_enabled) {

@patrick-werner patrick-werner requested a review from jkiddo April 10, 2025 16:37
@robogary
Copy link

Formatting check succeeded!

@patrick-werner patrick-werner removed the request for review from jkiddo April 10, 2025 17:28
@patrick-werner patrick-werner marked this pull request as draft April 10, 2025 17:29
@patrick-werner patrick-werner marked this pull request as ready for review April 30, 2025 08:58
@robogary
Copy link

Formatting check succeeded!

@robogary
Copy link

Formatting check succeeded!

@patrick-werner
Copy link
Member Author

as the patientMergeProvider is only available in R4, i have to update my code

@patrick-werner patrick-werner marked this pull request as draft April 30, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants